diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index c3975f9f62d9cb..b70e2306ca2d55 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -3623,6 +3623,8 @@ void Sema::mergeObjCMethodDecls(ObjCMethodDecl *newMethod, ni = newMethod->param_begin(), ne = newMethod->param_end(); ni != ne && oi != oe; ++ni, ++oi) mergeParamDeclAttributes(*ni, *oi, *this); + + CheckObjCMethodOverride(newMethod, oldMethod); } static void diagnoseVarDeclTypeMismatch(Sema &S, VarDecl *New, VarDecl* Old) { diff --git a/clang/lib/Sema/SemaDeclObjC.cpp b/clang/lib/Sema/SemaDeclObjC.cpp index d44b5f357df1ad..c17fde497ae771 100644 --- a/clang/lib/Sema/SemaDeclObjC.cpp +++ b/clang/lib/Sema/SemaDeclObjC.cpp @@ -4133,7 +4133,7 @@ class OverrideSearch { public: Sema &S; ObjCMethodDecl *Method; - llvm::SmallPtrSet Overridden; + llvm::SmallSetVector Overridden; bool Recursive; public: @@ -4170,7 +4170,7 @@ class OverrideSearch { } } - typedef llvm::SmallPtrSetImpl::iterator iterator; + typedef decltype(Overridden)::iterator iterator; iterator begin() const { return Overridden.begin(); } iterator end() const { return Overridden.end(); } @@ -4338,10 +4338,6 @@ void Sema::CheckObjCMethodOverrides(ObjCMethodDecl *ObjCMethod, // Then merge the declarations. mergeObjCMethodDecls(ObjCMethod, overridden); - } - - for (ObjCMethodDecl *overridden : overrides) { - CheckObjCMethodOverride(ObjCMethod, overridden); if (ObjCMethod->isImplicit() && overridden->isImplicit()) continue; // Conflicting properties are detected elsewhere. diff --git a/clang/test/SemaObjC/arc-decls.m b/clang/test/SemaObjC/arc-decls.m index c1c319d95e3cf0..15fb78be0899d0 100644 --- a/clang/test/SemaObjC/arc-decls.m +++ b/clang/test/SemaObjC/arc-decls.m @@ -154,3 +154,25 @@ @interface SomeClassOwnedByController () @property (readwrite, weak) ControllerClass *weak_controller; @end + +@interface I3 +@end + +@interface D3 : I3 +@end + +@interface D3 (Cat1) +- (id)method; +@end + +@interface I3 (Cat2) +// FIXME: clang should diagnose mismatch between methods in D3(Cat1) and +// I3(Cat2). +- (id)method __attribute__((ns_returns_retained)); +@end + +@implementation D3 +- (id)method { + return (id)0; +} +@end