From b33c028c3d9902ff121a4919d2ce871e09db30c6 Mon Sep 17 00:00:00 2001 From: Steven DeMartini Date: Sun, 23 Jun 2024 22:44:35 -0400 Subject: [PATCH] Simplify hook logic for mouse-down in image resizer --- src/extensions/ResizableImageResizer.tsx | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/extensions/ResizableImageResizer.tsx b/src/extensions/ResizableImageResizer.tsx index 0e36a42..b63d4c7 100644 --- a/src/extensions/ResizableImageResizer.tsx +++ b/src/extensions/ResizableImageResizer.tsx @@ -36,17 +36,18 @@ export function ResizableImageResizer({ const { classes, cx } = useStyles(); useEffect(() => { + if (!mouseDown) { + return; + } + + // If the user is currently holding down the resize handle, we'll have mouse + // movements fire the onResize callback (since the user would be "dragging" + // the handle). const handleMouseMove = (event: MouseEvent) => { onResize(event); }; - if (mouseDown) { - // If the user is currently holding down the resize handle, we'll have mouse - // movements fire the onResize callback (since the user would be "dragging" the - // handle) - window.addEventListener("mousemove", handleMouseMove); - } - + window.addEventListener("mousemove", handleMouseMove); return () => { window.removeEventListener("mousemove", handleMouseMove); };