Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mui v6 support #266

Closed
Xhale1 opened this issue Aug 29, 2024 · 4 comments · Fixed by #267
Closed

Mui v6 support #266

Xhale1 opened this issue Aug 29, 2024 · 4 comments · Fixed by #267

Comments

@Xhale1
Copy link
Contributor

Xhale1 commented Aug 29, 2024

Mui v6 released a few days ago, it'd be amazing to see this library support it someday!

I don't intend to rush anything, just wanted to log an issue to start some awareness. Love the library :)

@sjdemartini
Copy link
Owner

Agreed! This is on my radar. Also happy to accept a PR for this. 😄 From reading the release notes, I'm hoping it won't be too difficult to support both v5 and v6, but we'll see.

@Xhale1
Copy link
Contributor Author

Xhale1 commented Sep 1, 2024

Looks like this library might already support v6! I cloned the repo and updated the dependencies and the dev server, tests, linting, and type checking all look good!

I can start a PR, though I'm not sure what the best path forward would be for running tests on both mui v5 and mui v6. I can experiment with something similar to what I'm using in @hello-pangea/dnd though I'm not sold on that being the best implementation.

@Xhale1
Copy link
Contributor Author

Xhale1 commented Sep 1, 2024

I opened PR #267 :)

@Xhale1
Copy link
Contributor Author

Xhale1 commented Sep 11, 2024

Gonna close this as #267 got merged and released in v1.11.0

@Xhale1 Xhale1 closed this as completed Sep 11, 2024
@sjdemartini sjdemartini linked a pull request Sep 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants