Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Skooner support OIDC PKCE Auth #406

Open
rajakshay opened this issue Jun 13, 2023 · 3 comments
Open

Does Skooner support OIDC PKCE Auth #406

rajakshay opened this issue Jun 13, 2023 · 3 comments

Comments

@rajakshay
Copy link

Hello Skooner Team,

Is PKCE Auth Supported in Skooner?

I have gone through the doc: https://github.com/skooner-k8s/skooner#oidc
And the option of using OIDC_METADATA. But, looks like there is no option to choose PKCE in the client metadata: https://github.com/panva/node-openid-client/blob/main/docs/README.md#new-clientmetadata-jwks-options

And the option to do that would be in https://github.com/panva/node-openid-client/blob/main/docs/README.md#clientauthorizationurlparameters by setting code_challenge_method: 'S256', but there isn't an option to do that in skooner code: https://github.com/skooner-k8s/skooner/blob/ccbda174d55b9cec14aabe8f60fd4bce41531780/server/index.js#LL133C5-L133C60

Is there a plan on the roadmap to add this? If this is already supported in another way, a link to doc would help. Thanks.

@tianni4104
Copy link
Collaborator

@rajakshay Thanks for sharing your thoughts. I don't think we have a plan to add it so far. We're happy to accept contributions if anyone is interested.

@yuqiuw
Copy link
Collaborator

yuqiuw commented Sep 12, 2023

Try fixing in #411

@yuqiuw
Copy link
Collaborator

yuqiuw commented Sep 12, 2023

#414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants