Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Set jadx-gui default themes according to system light/dark mode #2279

Open
skylot opened this issue Sep 18, 2024 · 2 comments · May be fixed by #2281
Open

[feature] Set jadx-gui default themes according to system light/dark mode #2279

skylot opened this issue Sep 18, 2024 · 2 comments · May be fixed by #2281
Labels
GUI Issues in jadx-gui module new feature
Milestone

Comments

@skylot
Copy link
Owner

skylot commented Sep 18, 2024

Describe your idea

Most systems now provide option to use dark mode and default light theme in jadx-gui fit badly.
Using https://github.com/Dansoftowner/jSystemThemeDetector library, it should be easy to detect current theme mode and apply matching themes by default.

Created by discussion in #2278 (comment)
Related to #1763.

@skylot skylot added new feature GUI Issues in jadx-gui module labels Sep 18, 2024
@skylot skylot added this to the TBD milestone Sep 18, 2024
@Real-Packet
Copy link

I think dark theme should be default. I think light theme has less users, and light theme's disadvantage is literally that it is light theme, which means that, to make it not hurt when you see a light mode GUI for the first time of the day at 6 AM or so, you need less light colors like yellow or blue

@Real-Packet
Copy link

This seems an easy thing, I'm implementing this on my feat/gui/theme/sync branch.

@Real-Packet Real-Packet linked a pull request Sep 19, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issues in jadx-gui module new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants