Skip to content

Commit

Permalink
Merge pull request #197 from dblock/rubocop-0.58.2
Browse files Browse the repository at this point in the history
Upgraded RuboCop to 0.58.2.
  • Loading branch information
dblock committed Aug 27, 2018
2 parents 1708693 + 599f72c commit 9392b2a
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 50 deletions.
9 changes: 9 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,13 @@ AllCops:
- examples/**/vendor/**/*
- bin/**/*

Metrics:
Enabled: false

Metrics/LineLength:
Max: 512

Style/Documentation:
Enabled: false

inherit_from: .rubocop_todo.yml
77 changes: 28 additions & 49 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2018-05-04 16:44:32 -0400 using RuboCop version 0.51.0.
# on 2018-08-27 14:16:34 +0200 using RuboCop version 0.58.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
Layout/IndentHeredoc:
Exclude:
Expand All @@ -26,71 +26,50 @@ Lint/HandleExceptions:
- 'lib/initializers/giphy.rb'
- 'lib/initializers/giphy_client.rb'

# Offense count: 7
Metrics/AbcSize:
Max: 40

# Offense count: 30
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/BlockLength:
Max: 131

# Offense count: 1
# Configuration parameters: CountComments.
Metrics/ClassLength:
Max: 131

# Offense count: 2
Metrics/CyclomaticComplexity:
Max: 16

# Offense count: 252
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
Max: 151

# Offense count: 11
# Configuration parameters: CountComments.
Metrics/MethodLength:
Max: 27

# Offense count: 2
Metrics/PerceivedComplexity:
Max: 14

# Offense count: 1
# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
Naming/FileName:
# Cop supports --auto-correct.
Lint/UnneededCopEnableDirective:
Exclude:
- 'lib/slack-ruby-bot.rb'
- 'Gemfile'

# Offense count: 2
# Configuration parameters: EnforcedStyle, SupportedStyles.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: snake_case, normalcase, non_integer
Naming/VariableNumber:
Exclude:
- 'spec/slack-ruby-bot/hooks/set_spec.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect.
Performance/HashEachMethods:
# Configuration parameters: EnforcedStyle.
# SupportedStyles: inline, group
Style/AccessModifierDeclarations:
Exclude:
- 'lib/slack-ruby-bot/hooks/set.rb'

# Offense count: 34
Style/Documentation:
Enabled: false
- 'lib/slack-ruby-bot/hooks/hook_support.rb'

# Offense count: 1
Style/DoubleNegation:
Exclude:
- 'lib/slack-ruby-bot/commands/base.rb'

# Offense count: 5
# Cop supports --auto-correct.
Style/ExpandPathArguments:
Exclude:
- 'lib/config/application.rb'
- 'lib/config/environment.rb'
- 'lib/slack-ruby-bot.rb'
- 'slack-ruby-bot.gemspec'

# Offense count: 2
# Cop supports --auto-correct.
Style/IfUnlessModifier:
Exclude:
- 'lib/slack-ruby-bot/commands/support/match.rb'
- 'lib/slack-ruby-bot/mvc/controller/base.rb'

# Offense count: 2
# Configuration parameters: EnforcedStyle, SupportedStyles.
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: module_function, extend_self
Style/ModuleFunction:
Exclude:
Expand Down
2 changes: 1 addition & 1 deletion slack-ruby-bot.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'rack-test'
s.add_development_dependency 'rake'
s.add_development_dependency 'rspec'
s.add_development_dependency 'rubocop', '0.51.0'
s.add_development_dependency 'rubocop', '0.58.2'
s.add_development_dependency 'vcr'
s.add_development_dependency 'webmock'
end

0 comments on commit 9392b2a

Please sign in to comment.