Skip to content

Commit

Permalink
Update UPGRADING.md and CONTRIBUTING.md
Browse files Browse the repository at this point in the history
  • Loading branch information
dikond committed Apr 26, 2020
1 parent 7ae5d00 commit 9619e20
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ git remote add upstream https://github.com/slack-ruby/slack-ruby-bot.git

## Bundle Install and Test

First make sure you've installed all default gems
First make sure you've installed all default gems.

```
bundle install
Expand All @@ -30,13 +30,13 @@ To run the full specs suite you'll need to install one of the optional gems: `as
gem install async-websocket -v 0.8.0
```

Run specs with
Run specs with:

```
bundle exec rake CONCURRENCY=async-websocket
```

Take a look at travis configuration for more details.
Take a look at the [travis configuration](https://github.com/slack-ruby/slack-ruby-bot/blob/master/.travis.yml) for more details.


## Run SlackRubyBot in Development
Expand Down
8 changes: 8 additions & 0 deletions UPGRADING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
Upgrading SlackRubyBot
======================

### Upgrading to >= 0.14.1

#### Set up VCR explicitly

Requiring `slack-ruby-bot/rspec` won't set up [VCR](https://rubygems.org/gems/vcr) anymore. If your spec suite implicitly relies on this you would need to set up VCR explicitly in your spec suite. Just follow standard VCR documentation.

See issue [#257](https://github.com/slack-ruby/slack-ruby-bot/issues/257) for more details.

### Upgrading to >= 0.14.0

#### Bot Messages Disabled
Expand Down

0 comments on commit 9619e20

Please sign in to comment.