Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commands order is not guaranteed #75

Open
dblock opened this issue May 31, 2016 · 3 comments
Open

Commands order is not guaranteed #75

dblock opened this issue May 31, 2016 · 3 comments
Labels
confirmed bug

Comments

@dblock
Copy link
Collaborator

dblock commented May 31, 2016

https://github.com/dblock/slack-market is behaving differently between development and production, notably bought XYZ is matching a later declared match route.
@dblock dblock closed this as completed in fe27b4c May 31, 2016
@dblock
Copy link
Collaborator Author

dblock commented May 31, 2016

Because of https://github.com/dblock/slack-ruby-bot/blob/19b48982e391d06e8ba35eb40c6d49035fa4f431/lib/slack-ruby-bot/hooks/message.rb#L29

@dblock dblock reopened this May 31, 2016
gconklin added a commit to gconklin/slack-ruby-bot that referenced this issue Nov 7, 2016
@gconklin
slack-ruby#75 Commands order is not guaranteed
cab94d8
gconklin added a commit to gconklin/slack-ruby-bot that referenced this issue Nov 7, 2016
@gconklin
slack-ruby#75 Commands order is not guaranteed
729da1f
gconklin added a commit to gconklin/slack-ruby-bot that referenced this issue Nov 7, 2016
@gconklin
Commands order slack-ruby#75 notes
4f2bbed
gconklin added a commit to gconklin/slack-ruby-bot that referenced this issue Nov 7, 2016
@gconklin
slack-ruby#75 Commands order is not guaranteed
3f410a2
gconklin added a commit to gconklin/slack-ruby-bot that referenced this issue Nov 7, 2016
@gconklin
Commands order slack-ruby#75 notes
8adb2e7
@gconklin gconklin mentioned this issue Nov 7, 2016
Merged
gconklin added a commit to gconklin/slack-ruby-bot that referenced this issue Nov 7, 2016
@gconklin
Commands order slack-ruby#75 notes
2fc10b5
gconklin added a commit to gconklin/slack-ruby-bot that referenced this issue Nov 7, 2016
@gconklin
Commands order slack-ruby#75 notes
d30468a
gconklin added a commit to gconklin/slack-ruby-bot that referenced this issue Nov 8, 2016
@gconklin
Issue slack-ruby#75 maintain an ordered list of command classes
b1c7327 
Commands order slack-ruby#75 notes

maintain an array of registered command classes
gconklin added a commit to gconklin/slack-ruby-bot that referenced this issue Nov 14, 2016
@gconklin
Issue slack-ruby#75 maintain an ordered list of command classes
f2d09ce
@laertispappas
Copy link
Contributor

What is the status on this one?

@dblock
Copy link
Collaborator Author

dblock commented Jun 20, 2017

No progress on my side @laertispappas.

@dblock dblock mentioned this issue Jun 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblock @laertispappas