Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lp/on serve instance methods #147

Merged
merged 4 commits into from
Jun 26, 2017
Merged

Lp/on serve instance methods #147

merged 4 commits into from
Jun 26, 2017

Conversation

laertispappas
Copy link
Contributor

@dblock
Copy link
Collaborator

dblock commented Jun 23, 2017

Do update UPGRADING as well and this is good to be merged.

@laertispappas
Copy link
Contributor Author

laertispappas commented Jun 23, 2017 •
edited
Loading

@dblock Thanks for the reply I just wanted a feedback first. I will proceed and update UPGRADING file. Thanks

@laertispappas
Copy link
Contributor Author

@dblock Done please take a look.

@dblock dblock merged commit 26240b3 into slack-ruby:master Jun 26, 2017
@dblock
Copy link
Collaborator

dblock commented Jun 26, 2017

Merged

@dblock dblock mentioned this pull request Mar 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laertispappas @dblock