Allow frozen string in hooks message #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow frozen string in Hooks::Message - [@jonosenior](https://github.com/jonosenior)Generated by 🚫 danger |
jnsya
force-pushed
the
allow-frozen-string-in-hooks-message
branch
from
567a008
to
7ae62cd
Compare
|
Thanks for this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our code we currently use
frozen_string_literal: true. This causes an error because the slack-ruby-bot is trying to mutate a string.We only fixed and created a test for the example we found, but there might be more.
Would you be open to using frozen_string_literal by default? I would be open to do that if you want.