Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #195: get stock prices from IEX #220

Merged
merged 3 commits into from
Apr 19, 2019
Merged

issue #195: get stock prices from IEX #220

merged 3 commits into from
Apr 19, 2019

Conversation

corprew
Copy link
Contributor

@corprew corprew commented Apr 19, 2019

examples/market now pulls from IEX client instead of defunct yahoo stock market API.

@corprew
Copy link
Contributor Author

corprew commented Apr 19, 2019 •
edited
Loading

Well, the build is failing silently on The command "bundle exec danger" exited with 1. although I think I resolved the issue with the danger pr bot and it got caught up in the --amend commit that the contributing intructions asked for. I'm going to wait for feedback here as scanning through the danger gem instructions wasn't fruitful.

dblock
dblock requested changes Apr 19, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
examples/market/marketbot.rb Show resolved Hide resolved
@corprew
prbot has a variety of invisible requirements for passing PRs, and do…
073423f 
…esn't produce any output telling you what issues are
corprew
corprew commented Apr 19, 2019
View reviewed changes
Copy link
Contributor Author

@corprew corprew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, i have made a commit making the requested changes from @dblock's review.

@dblock dblock merged commit 25f9384 into slack-ruby:master Apr 19, 2019
@dblock
Copy link
Collaborator

dblock commented Apr 19, 2019

Thanks, merged.

Give https://github.com/dblock/iex-ruby-client a try on HEAD? That now requires registration, I think we (you) can create an app and commit its publishable key here.

@dblock
Copy link
Collaborator

dblock commented Apr 24, 2019

iex-ruby-client 1.0 has shipped, followup on this?

@corprew
Copy link
Contributor Author

corprew commented May 28, 2019

I should be able to do this around 6/15 when I get back from traveling. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corprew @dblock