Use config.token and config.aliases if set

CHANGELOG.md

@@ -1,6 +1,7 @@
 ### 0.14.1 (Next)
 
 * Your contribution here.
+* [#254](https://github.com/slack-ruby/slack-ruby-bot/pull/254): Allow setting of config.token in initializer - [@wasabigeek](https://github.com/wasabigeek).
 * [#253](https://github.com/slack-ruby/slack-ruby-bot/pull/253): Remove reference to unsupported Giphy content rating - [@wasabigeek](https://github.com/wasabigeek).
 
 ### 0.14.0 (2020/4/2)

lib/slack-ruby-bot/app.rb

@@ -3,13 +3,6 @@
 module SlackRubyBot
   class App < Server
     def initialize(options = {})
-      SlackRubyBot.configure do |config|
-        config.token = ENV['SLACK_API_TOKEN'] || raise("Missing ENV['SLACK_API_TOKEN'].")
-        config.aliases = ENV['SLACK_RUBY_BOT_ALIASES'].split(' ') if ENV['SLACK_RUBY_BOT_ALIASES']
-      end
-      Slack.configure do |config|
-        config.token = SlackRubyBot.config.token
-      end
       super
     end
 
@@ -18,11 +11,27 @@ def config
     end
 
     def self.instance
-      @instance ||= new
+      @instance ||= begin
+        configure!
+        new
+      end
     end
 
     private
 
+    def self.configure!
+      SlackRubyBot.configure do |config|
+        config.token ||= ENV['SLACK_API_TOKEN']
+        raise("Missing ENV['SLACK_API_TOKEN'].") if config.token.nil?
+
+        config.aliases = ENV['SLACK_RUBY_BOT_ALIASES'].split(' ') if ENV['SLACK_RUBY_BOT_ALIASES']
+      end
+      Slack.configure do |config|
+        config.token = SlackRubyBot.config.token
+      end
+    end
+    private_class_method :configure!
+
     def hello(client, _data)
       if client.team && client.self
         SlackRubyBot.configure do |config|

lib/slack-ruby-bot/rspec/support/slack-ruby-bot/it_behaves_like_a_slack_bot.rb

@@ -1,15 +1,49 @@
 # frozen_string_literal: true
 
 shared_examples 'a slack ruby bot' do
+  let(:token) { 'slack-api-token' }
+
   context 'not configured' do
     before do
       @slack_api_token = ENV.delete('SLACK_API_TOKEN')
+      SlackRubyBot.configure { |config| config.token = nil }
     end
     after do
       ENV['SLACK_API_TOKEN'] = @slack_api_token
     end
     it 'requires SLACK_API_TOKEN' do
-      expect { subject }.to raise_error RuntimeError, "Missing ENV['SLACK_API_TOKEN']."
+      expect { described_class.instance }.to raise_error RuntimeError, "Missing ENV['SLACK_API_TOKEN']."
+    end
+  end
+
+  context 'when SLACK_API_TOKEN is defined in ENV but not config' do
+    it 'sets config.token from ENV' do
+      allow(ENV).to receive(:[]).and_call_original.at_least(:once)
+      allow(ENV).to receive(:[]).with('SLACK_API_TOKEN').and_return(token)
+      SlackRubyBot.configure { |config| config.token = nil }
+
+      expect(described_class.instance.config.token).to eq(token)
+    end
+  end
+
+  context 'when SLACK_API_TOKEN is not defined in ENV but is defined in config' do
+    it 'sets config.token from config' do
+      allow(ENV).to receive(:[]).at_least(:once)
+      allow(ENV).to receive(:[]).with('SLACK_API_TOKEN').and_return(nil)
+      SlackRubyBot.configure { |config| config.token = token }
+
+      expect(described_class.instance.config.token).to eq(token)
+    end
+  end
+
+  context 'when SLACK_API_TOKEN is defined in ENV and config' do
+    it 'sets config.token from config' do
+      token2 = 'another-api-token'
+      allow(ENV).to receive(:[]).at_least(:once)
+      allow(ENV).to receive(:[]).with('SLACK_API_TOKEN').and_return(token2)
+      SlackRubyBot.configure { |config| config.token = token }
+
+      expect(described_class.instance.config.token).to eq(token)
     end
   end
 end