Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added active-support dependency. #271

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Aug 2, 2020

We removed a dependency on activesupport in slack-ruby/slack-ruby-client#325, but it's needed by the command classes in this library.

Closes #270

@dangerpr-bot
Copy link

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

@dblock dblock merged commit 9364f2e into slack-ruby:master Oct 14, 2020
@juanibiapina
Copy link

When do you plan to release this?

@dblock
Copy link
Collaborator Author

dblock commented Nov 6, 2020

When do you plan to release this?

When I have time. It shouldn’t be blocking you, just add the dependency in your Gemfile.

@dblock dblock deleted the active-support branch November 30, 2020 15:04
@dblock
Copy link
Collaborator Author

dblock commented Dec 4, 2020

I released this in 0.16.1. Consider investing in migrating to granular scopes from RTM, https://code.dblock.org/2020/11/30/migrating-classic-slack-ruby-bots-to-granular-permissions.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pongbot does not run on linux mint 19
3 participants