Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RegexpError when parsing command #30

Merged
merged 1 commit into from
Nov 26, 2015

Conversation

kuboshizuma
Copy link
Contributor

Regexp error happens when receiving meta character for commands.
This commit makes commands escaped.

@kuboshizuma
Copy link
Contributor Author

Oops, should we change settings for RuboCop?

lib/slack-ruby-bot/commands/base.rb:3:5: C: Class has too many lines. [101/100]
    class Base
    ^^^^^
62 files inspected, 1 offense detected
RuboCop failed!

@dblock
Copy link
Collaborator

dblock commented Nov 25, 2015

This is great, thanks! Update CHANGELOG please. For RuboCop run rubocop --auto-gen-config. Commit via --amend.

@kuboshizuma
Copy link
Contributor Author

Thank you for changing settings for RuboCop!
Now, update commit following your comment.

@dblock
Copy link
Collaborator

dblock commented Nov 26, 2015

Still needs an entry in CHANGELOG, please.

@kuboshizuma
Copy link
Contributor Author

I commit again for CHANGELOG.
Is it all right?

@dblock
Copy link
Collaborator

dblock commented Nov 26, 2015

Looks great, merging. Thanks.

dblock added a commit that referenced this pull request Nov 26, 2015
@dblock dblock merged commit 8b6cce7 into slack-ruby:master Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants