-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize the App class .instance is called on #33
Conversation
Very nice. I'd love a CHANGELOG entry and a test for this, please? |
happy to... will update this evening |
Bump @dmvt, want to cut a release soon would be nice to get this. |
Sorry I missed the cut |
@@ -1,5 +1,6 @@ | |||
### 0.5.1 (Next) | |||
|
|||
* [#33](https://github.com/dblock/slack-ruby-bot/pull/33): `SlackRubyBot::App.instance` now creates an instance of the class on which it is called. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this look like all the other changelog lines with a link to your Github profile.
No big deal, next cut. Can you squash your commits, too, please. |
Initializes the subclass (for instance `PongBot::App` in the first `README` example) instead of `SlackRubyBot::App` specifically. This allows for easier behavior modification through custom `Hooks` and direct method overriding.
All set :) |
👍 |
Initialize the App class .instance is called on
Initializes the subclass (for instance
PongBot::App
in the firstREADME
example) instead ofSlackRubyBot::App
specifically. This allows for easier behavior modification through customHooks
and direct method overriding.