Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a couple of problems in TUTORIAL.md #98

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

edruder
Copy link
Contributor

@edruder edruder commented Oct 12, 2016

  1. foreman start crashes unless the celluloid-io (or similar) gem is installed. (Maybe it should be brought in by slack-ruby-bot?)
  2. Renamed the "app spec" to be a "bot spec", to match the source code.
  3. The specs fail unless subject is defined.

@dblock
Copy link
Collaborator

dblock commented Oct 12, 2016

Thanks! The bot can work with either Celluloid or Eventmachine, so we don't want to force it as a dependency. Makes sense in the tutorial of course.

@dblock dblock merged commit 3c73542 into slack-ruby:master Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants