From 40f4becb1eab96920d8bfd59019cdb9358a94122 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Deividas=20Kar=C5=BEinauskas?=
 <deividas.karzinauskas@gmail.com>
Date: Thu, 8 Aug 2024 17:22:15 +0300
Subject: [PATCH] Fix write target nil dereferences (#14059)

* Hardcoded value for call with exact gas

* Record gasProvided in route function

* Add a getter for transmission gas limit

* Update snapshot

* Changeset

* Remove unused import

* Rename to gas limit

* Update gethwrappers

* Uncomment test code

* Remove copy/pasta comment

* Slight rename

* Allow retrying transmissions with more gas

* Only allow retrying failed transmissions

* Update snapshot

* Fix state for InvalidReceiver check

* Check for initial state

* Actually store gas limit provided to receiver

* Update gethwrappers

* Remove unused struct

* Correctly mark invalid receiver when receiver interface unsupported

* Create TransmissionInfo struct

* Update gethwrappers

* Bump gas limit

* Bump gas even more

* Update KeystoneFeedsConsumer.sol to implement IERC165

* Use getTransmissionInfo

* Use TransmissionState to determine if transmission should be created

* Fix test

* Fix trailing line

* Update a mock to the GetLatestValue("getTransmissionInfo") call in a test

* Remove TODO + replace panic with err

* Remove redundant empty lines

* Typo

* Fix nil pointer dereference in write target implementation

* Remove unused constant

* Name mapping values

* Add changeset

---------

Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
---
 .changeset/shy-windows-juggle.md              |  5 +++
 core/capabilities/targets/write_target.go     |  8 +++++
 .../capabilities/targets/write_target_test.go | 32 ++++++++++++++++---
 3 files changed, 41 insertions(+), 4 deletions(-)
 create mode 100644 .changeset/shy-windows-juggle.md

diff --git a/.changeset/shy-windows-juggle.md b/.changeset/shy-windows-juggle.md
new file mode 100644
index 00000000000..0408383bd03
--- /dev/null
+++ b/.changeset/shy-windows-juggle.md
@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal
diff --git a/core/capabilities/targets/write_target.go b/core/capabilities/targets/write_target.go
index cc3a58b482e..4524c4fd449 100644
--- a/core/capabilities/targets/write_target.go
+++ b/core/capabilities/targets/write_target.go
@@ -76,6 +76,10 @@ type EvmConfig struct {
 }
 
 func parseConfig(rawConfig *values.Map) (config EvmConfig, err error) {
+	if rawConfig == nil {
+		return config, fmt.Errorf("missing config field")
+	}
+
 	if err := rawConfig.UnwrapTo(&config); err != nil {
 		return config, err
 	}
@@ -117,6 +121,10 @@ func (cap *WriteTarget) Execute(ctx context.Context, request capabilities.Capabi
 		return nil, err
 	}
 
+	if request.Inputs == nil {
+		return nil, fmt.Errorf("missing inputs field")
+	}
+
 	signedReport, ok := request.Inputs.Underlying[signedReportField]
 	if !ok {
 		return nil, fmt.Errorf("missing required field %s", signedReportField)
diff --git a/core/capabilities/targets/write_target_test.go b/core/capabilities/targets/write_target_test.go
index 13305fe7ef9..0fa750911dd 100644
--- a/core/capabilities/targets/write_target_test.go
+++ b/core/capabilities/targets/write_target_test.go
@@ -134,10 +134,10 @@ func TestWriteTarget(t *testing.T) {
 	})
 
 	t.Run("fails with invalid config", func(t *testing.T) {
-		invalidConfig, err := values.NewMap(map[string]any{
+		invalidConfig, err2 := values.NewMap(map[string]any{
 			"Address": "invalid-address",
 		})
-		require.NoError(t, err)
+		require.NoError(t, err2)
 
 		req := capabilities.CapabilityRequest{
 			Metadata: capabilities.RequestMetadata{
@@ -146,7 +146,31 @@ func TestWriteTarget(t *testing.T) {
 			Config: invalidConfig,
 			Inputs: validInputs,
 		}
-		_, err = writeTarget.Execute(ctx, req)
-		require.Error(t, err)
+		_, err2 = writeTarget.Execute(ctx, req)
+		require.Error(t, err2)
+	})
+
+	t.Run("fails with nil config", func(t *testing.T) {
+		req := capabilities.CapabilityRequest{
+			Metadata: capabilities.RequestMetadata{
+				WorkflowID: "test-id",
+			},
+			Config: nil,
+			Inputs: validInputs,
+		}
+		_, err2 := writeTarget.Execute(ctx, req)
+		require.Error(t, err2)
+	})
+
+	t.Run("fails with nil inputs", func(t *testing.T) {
+		req := capabilities.CapabilityRequest{
+			Metadata: capabilities.RequestMetadata{
+				WorkflowID: "test-id",
+			},
+			Config: config,
+			Inputs: nil,
+		}
+		_, err2 := writeTarget.Execute(ctx, req)
+		require.Error(t, err2)
 	})
 }