Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get "fgrep is obsolescent" when run 'sml' on Fedora #286

Closed
2 of 12 tasks
rgizz opened this issue Nov 14, 2023 · 1 comment
Closed
2 of 12 tasks

Get "fgrep is obsolescent" when run 'sml' on Fedora #286

rgizz opened this issue Nov 14, 2023 · 1 comment
Assignees
@JohnReppy
Labels
bug Something isn't working fixed-in-110.99.5 issues that will be fixed in the 110.99.5 version linux

Comments

@rgizz
Copy link

rgizz commented Nov 14, 2023

Version

110.99.4 (Latest)

Operating System

  • Any
  • Linux
  • macOS
  • Windows
  • Other Unix

OS Version

Fedora 38

Processor

  • Any
  • Arm (using Rosetta)
  • PowerPC
  • Sparc
  • x86 (32-bit)
  • x86-64 (64-bit)
  • Other

System Component

Command-line tool

Severity

Cosmetic

Description

When I type 'sml' on the command line, I get a warning that "fgrep is obsolescent" before the Smlnj repl launches. It works fine, so this is simply cosmetic.

Transcript

$ sml
fgrep: warning: fgrep is obsolescent; using grep -F
Standard ML of New Jersey (64-bit) v110.99.4 [built: Tue Nov 14 10:09:53 2023]

Expected Behavior

$ sml
Standard ML of New Jersey (64-bit) v110.99.4 [built: Tue Nov 14 10:09:53 2023]

Steps to Reproduce

Just launch repl by typing 'sml'

Additional Information

It seems to arise from two uses of fgrep in bin/.run-sml, on lines 168 and 172. If I replace 'fgrep' with 'grep -F' on those two lines the warning goes away.

Email address

gztown2216@yahoo.com
@rgizz rgizz added the bug Something isn't working label Nov 14, 2023
@JohnReppy JohnReppy added linux fixed-in-110.99.5 issues that will be fixed in the 110.99.5 version labels Nov 14, 2023
@JohnReppy JohnReppy self-assigned this Nov 14, 2023
@JohnReppy
Copy link
Contributor

This issue has already been addressed (1346e96) and will be fixed in 110.99.5.

@MatthewFluet MatthewFluet mentioned this issue Dec 14, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnReppy JohnReppy

Labels
bug Something isn't working fixed-in-110.99.5 issues that will be fixed in the 110.99.5 version linux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohnReppy @rgizz