Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of instant crate imcompatible w/ MIT license? #54

Closed
zeenix opened this issue Mar 4, 2023 · 3 comments · Fixed by #60
Closed

Use of instant crate imcompatible w/ MIT license? #54

zeenix opened this issue Mar 4, 2023 · 3 comments · Fixed by #60

Comments

@zeenix
Copy link
Member

zeenix commented Mar 4, 2023

I ran cargo lichking check against zbus and according to that BSD-3-Clause license of instant is incompatible with MIT license of zbus. Seems this is the only crate that brings in this dep. IANAL so can't be sure this is a problem but I wanted to bring this to attention.

@smol-rs/admins ?

@notgull
Copy link
Member

notgull commented Mar 4, 2023

IANAL, but if I remember right the main restriction of the BSD 3 clause license over the MIT/Apache2 license is that you can't use the package for advertising. Realistically I don't think this is an issue, since there are plenty of MIT-licensed packages that use instant (winit comes to mind).

@notgull
Copy link
Member

notgull commented Mar 5, 2023

Seems this is the only crate that brings in this dep.

async-lock also uses the instant crate, as a heads up.

@zeenix
Copy link
Member Author

zeenix commented Mar 6, 2023

IANAL, but if I remember right the main restriction of the BSD 3 clause license over the MIT/Apache2 license is that you can't use the package for advertising.

Right and in general when you statically link two libs under different licenses, doesn't the more restrictive license becomes the effective one?

Realistically I don't think this is an issue, since there are plenty of MIT-licensed packages that use instant (winit comes to mind).

True. That does make it unlikely that there is a problem but if there is a problem, I don't think "others are doing it too" argument would hold in a court. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants