Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDB Loader: migrate to slf4j logging #598

Open
chuwy opened this issue Oct 16, 2021 · 0 comments
Open

RDB Loader: migrate to slf4j logging #598

chuwy opened this issue Oct 16, 2021 · 0 comments

Comments

@chuwy
Copy link
Contributor

chuwy commented Oct 16, 2021

Currently we use our own Logging algebra, which allows us to test logging and abstract it away, however it's very unflexible.

  1. It doesn't allow to disable logging for some classes at launch time
  2. It doesn't show where logging is coming from
  3. It doesn't allow to configure severity

log4cats gives us these abilities, but unfortunately has another downside - we need to either abandon F[_]: Logging signatures and instantiate one logger per class (and damage testing) or have Main class everywhere, which defeats 1st and 2nd points.

There's some WIP in log4cats I hope to get merged at some point (typelevel/log4cats#421, typelevel/log4cats#397). When the PR is merged we can migrate without trade-offs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant