Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect Reason #3237

Open
Valodya opened this issue May 4, 2018 · 1 comment
Open

Disconnect Reason #3237

Valodya opened this issue May 4, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@Valodya
Copy link

Valodya commented May 4, 2018

Note: for support questions, please use one of these channels: stackoverflow or slack

You want to:

  • [] report a bug
  • [x ] request a feature

Current behaviour

Server can disconnect a client only without reason

io.on('connection', (socket) => {
  setTimeout(() => socket.disconnect(true), 5000);
});

Steps to reproduce (if the current behaviour is a bug)

Note: the best way to get a quick answer is to provide a failing test case, by forking the following fiddle for example.

Expected behaviour

I'm looking for a way to disconnect a client with some reason (on the server), for example:

  • connection session time exceeded
  • user-token has become invalid
  • or something else

in the end I would like to have something like this:

//server
io.on('connection', (socket) => {
  setTimeout(() => {
     socket.disconnect(true, 'My super reason why the connection has been disconnected')
  }, 5000);
});

//client
socket.on('disconnect', (reason) => {
  // reason === 'My super reason why the connection has been disconnected'
});

please let me know if you are going to add the feature in future, or maybe there are any problems to implement it.

Setup

  • OS: any
  • browser: any
  • socket.io version: latest

Other information (e.g. stacktraces, related issues, suggestions how to fix)

@tomas-correia
Copy link

This would be more than helpful to avoid nasty custom "disconnect_reason" events, I second this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants