Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework file structure & license header. #89

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Rework file structure & license header. #89

merged 4 commits into from
Jun 2, 2022

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Jun 2, 2022

Tidy up the file structure including require_relative where it makes sense.

Types of Changes

  • Maintenance.

spec/spec_helper.rb Outdated Show resolved Hide resolved
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good compatibility workout!

@ioquatix
Copy link
Member Author

ioquatix commented Jun 2, 2022

@olleolleolle I hope it's sufficient, this gem has a lot of downloads.

spec/spec_helper.rb Outdated Show resolved Hide resolved
@texpert
Copy link

texpert commented Jun 9, 2022

Excuse me, but why all these hardcoded warnings' noise in the logs now?

@ioquatix
Copy link
Member Author

ioquatix commented Jun 9, 2022

Because you updated the gem and we are emitting warnings for files that will eventually be removed because they are clobbering global namespace/paths.

@texpert
Copy link

texpert commented Jun 9, 2022

Because you updated the gem and we are emitting warnings for files that will eventually be removed because they are clobbering global namespace/paths.

I understand the primary reason, but then there was #91, where all these constants where deprecated via Object.deprecate_constant, so now the uncoditional warnings are just a bothering noise.

@ioquatix
Copy link
Member Author

ioquatix commented Jun 9, 2022

The files and the constants they define are two separate issues with separate warnings.

It sounds like you are suggesting to remove the explicit warnings from the files. It's probably better we just fix the dependencies. If you don't want to deal with the warnings, stay with the old versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants