-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeyboardAvodingView implemented with useAnimatedKeyboard doesn't work after 3.0.0-rc.10 #4324
Comments
Hey @terrysahaidak, thanks for opening this issue, we will take care of this. |
@terrysahaidak Thanks again for reporting the issue and providing a helpful reproducer. I believe this issue has been fixed with #4266 and #4329 which was merged recently. It looks like the problem you have mentioned does no longer occur on 2fe3e38. Here's a video recording: it.works.mp4Watching the video in slow motion, there's still 1-2 frames of delay but this is a separate issue and we're actively working on it, so I'm closing this issue. Thanks again! |
Nice! Thanks a lot! Any ETA for the new Reanimated release? |
@terrysahaidak Not decided yet but probably next week |
Ah dang it, just stumbled across this issue. But glad it has been fixed. I haven't checked the PRs yet, but is this also going to be backported for REA2? |
@hirbod we're planning to drop support for 2.x soon, do you need this backported to v2? |
We're still not able to upgrade to v3 in our project. It would be convenient, since I have the same issue on v2 but if your schedule is tight, I would instead use https://github.com/kirillzyusko/react-native-keyboard-controller which I have used in the past (before there was useAnimatedKeyboard) which does the same as useAnimatedKeyboard and a bit more |
Description
After upgrading to the latest Reanimated version (for my tests i used the latest commit as for today
2d3016b8dcc482f51422c144eef58bf4657b7792
) and my custom implementation of KeyboardAvoidingView doesn't always work.Here you can see that the log inside of
useAnimatedStyle
is reporting changes for thekeyboard.height
, but the actual change is not applied to the view until i click somewhere. The same happens when i callKeyboard.dismiss()
.If was working in
3.0.0-rc.10
.But when the scroll view by dragging dismissing the keyboard it actually animates the height.
2023-04-03.17.06.13.mov
Steps to reproduce
Snack or a link to a repository
https://github.com/terrysahaidak/UseAnimatedKeyboardBug1
Reanimated version
3.0.2 and
2d3016b8dcc482f51422c144eef58bf4657b7792
commitReact Native version
0.71.5
Platforms
iOS
JavaScript runtime
Hermes
Workflow
React Native (without Expo)
Architecture
Paper (Old Architecture)
Build type
Debug mode
Device
iOS simulator
Device model
No response
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: