[0.72.0-rc.5] Event: you must return a valid, non-value from getEventData

[tomekzaw]

Description

The following error appears when using react-native-screens@3.20.0 with react-native@0.72.0-rc.5 with Fabric enabled:

The root cause is that react-native-screens sends an event with name onAttached with null payload which apparently is no longer supported.

Steps to reproduce

1. Run FabricExample app.

Snack or a link to a repository

https://github.com/software-mansion/react-native-reanimated/tree/%40tomekzaw/72rc5

Screens version

3.20.0

React Native version

0.72.0-rc.5

Platforms

Android

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Fabric (New Architecture)

Build type

Debug mode

Device

Android emulator

Device model

No response

Acknowledgements

Yes

[github-actions]

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

[cortinico]

@tomekzaw do you have any idea on what might be happening here? I worked on Fabric Interop for 0.72 and we had to work on the Event pipeline for Android, but the problem you're reporting seems unrelated 🤔

[tomekzaw]

@cortinico Most likely that's because we send events with null payload, see here:

react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt

Line 83 in 6272e44

sendEvent("onAttached", null)

[cortinico]

yeah that's most likely the cause

[kmagiera]

ccing @WoLewicki – will you have some time to look into this one?

[WoLewicki]

Yeah, I'll do it ASAP.

[WoLewicki]

Could you take a look if #1783 fixes the issue?

[tomekzaw]

@WoLewicki Works like a charm. 👏

Closing this issue as it was fixed in #1783 and released in 3.21.0.