Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create acl and resource at the same time #76

Closed
Otto-AA opened this issue Nov 16, 2019 · 4 comments
Closed

Create acl and resource at the same time #76

Otto-AA opened this issue Nov 16, 2019 · 4 comments

Comments

@Otto-AA
Copy link

Otto-AA commented Nov 16, 2019

Afaik, we currently have to create a resource, then check the link header for the acl location and then create the acl file for it. If the acl file creation fails (or just takes a longer period of time), the resource will be visible to others who shouldn't be able to access it.

To prevent this, I think we would need to make the acl file before or at least at the same time as the resource. I'd suggest making them simultaneously, because then it can't happen that one succeeds and the other fails.

@dmitrizagidulin
Copy link
Member

dmitrizagidulin commented Nov 16, 2019

Hi @Otto-AA, you're absolutely right, this is definitely a problem developers face. In the overall Solid spec repo, we're discussing how to solve it (largely coming to the same consensus as you suggest, of tying the lifecycle of the resource + its ACL together) - solid/specification#58

@akuckartz
Copy link

akuckartz commented Nov 17, 2019

The default (without ACL file) is that everybody can access the resource? Can that default be changed? Maybe by inheriting it?

@Otto-AA
Copy link
Author

Otto-AA commented Nov 17, 2019

@akuckartz A folder can specify if permissions will be inherited to files without an acl. So if /foo/ says, that per default only user X has access, then for /foo/bar.ttl without /foo/bar.ttl.acl also only user X has access. The problem is if we want /foo/bar.ttl to only be accessed by user Y instead.
For more infos on inheritance: https://github.com/solid/web-access-control-spec#acl-inheritance-algorithm

@Otto-AA
Copy link
Author

Otto-AA commented Nov 17, 2019

@dmitrizagidulin Thanks for the information. This is exactly what I referred to (and more). I will close this issue in favor of the other.

@Otto-AA Otto-AA closed this as completed Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants