Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Higher level interface for applying promotions #2593

Closed
jhawthorn opened this issue Feb 21, 2018 · 0 comments
Closed

RFC: Higher level interface for applying promotions #2593

jhawthorn opened this issue Feb 21, 2018 · 0 comments

Comments

@jhawthorn
Copy link
Contributor

Our current promotion interface often doesn't allow the desired behaviour.

We want all promotions to calculate a promotion amount at a line-item level, but often stores want to emulate a per-order discount. This results in calculators like DistributedAmount which attempt to do this, but are awkward and involve error prone recalculations involving the whole order per-line item.

I believe we should take the lessons learned addressing similar issues in taxation #1892, and try to apply them to promotions.

@solidusio solidusio locked and limited conversation to collaborators Sep 7, 2022
@waiting-for-dev waiting-for-dev converted this issue into discussion #4603 Sep 7, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants