Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misconfigured oidc secret is difficult to identify and causes gloo to not start #10067

Open
huzlak opened this issue Sep 19, 2024 · 1 comment
Labels
Area: Stability Issues related to stability of the product, engineering, tech debt Type: Bug Something isn't working zendesk

Comments

@huzlak
Copy link
Contributor

huzlak commented Sep 19, 2024

Gloo Edge Product

Enterprise

Gloo Edge Version

v1.16.9

Kubernetes Version

v1.27.0

Describe the bug

Having a misconfigured oidc secret may cause the gloo pods to not come up. It prints an error that it fails to unmarshall a secret, but doesn't provide details on which secret is the problematic one.
Current error message looks like:

{"level":"error","ts":"2024-09-02T09:21:56.687Z","logger":"gloo-ee.v1.event_loop.setup.v1.event_loop.syncer","caller":"discovery/run.go:58","msg":"error in EDS: error in eds plugin : reading
 secret data into *v1.Secret: json: cannot unmarshal string into Go value of type map[string]json.RawMessage","version":"1.16.9","stacktrace":"[github.com/solo-io/gloo/projects/gloo/pkg/disco](http://github.com/solo-io/gloo/projects/gloo/pkg/disco)
very.(*syncer).Sync.func1\n\t/go/pkg/mod/github.com/solo-io/gloo@v1.16.12/projects/gloo/pkg/discovery/run.go:58"}

Example of the misconfiguration:
wrong secret value:
oauth: clientSecret:<SECRET_VALUE>

correct secret value:
oauth: 'clientSecret: <SECRET_VALUE>'

Expected Behavior

I expect gloo to come up, but the authconfig to be in ERROR state stating that it's secret could not be unmarshalled. Also the error message in gloo pod should be specific about which secret is causing the issue.

Steps to reproduce the bug

Misconfigure a secret and restart gloo pod

Additional Environment Detail

No response

Additional Context

No response

@huzlak huzlak added the Type: Bug Something isn't working label Sep 19, 2024
@soloio-bot
Copy link

Zendesk ticket #4429 has been linked to this issue.

@DuncanDoyle DuncanDoyle added the Area: Stability Issues related to stability of the product, engineering, tech debt label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Stability Issues related to stability of the product, engineering, tech debt Type: Bug Something isn't working zendesk
Projects
None yet
Development

No branches or pull requests

3 participants