gatewayProxies deployment's .kind.deployment.priorityClassName is not implemented

[zelig81]

Gloo Edge Product

Open Source

Gloo Edge Version

1.14.21

Kubernetes Version

v1.26.8

Describe the bug

when I set priorityClassName in values of helm chart for gatewayProxy (in gatewayProxies.NAME.kind.deployment.priorityClassName) it is not set on the resulting NAME deployment. The proxies are created though.

example of values:

...
gatewayProxies:
  gatewayProxy:
    kind:
      deployment:
        priorityClassName: cluster-critical-priority-preempting
...
  internalProxy:
    kind:
      deployment:
        priorityClassName: cluster-critical-priority-preempting
...

Expected Behavior

resulting deployments for gateway-proxy and internal-proxy should contain priorityClassName

Steps to reproduce the bug

helm install ...

Additional Environment Detail

No response

Additional Context

after having a look on gateway proxy template, I see that .kind.deployment is in use only for configuration of replicas, customEnv and affinity specifically. Could you please add the absent values per documentation for gatewayProxies.NAME.kind.deployment.XXXXXX to be set in the resulting deployments?

(most important for me are nodeSelector and priorityClassName)

As possible solution - kubeResourceOverride can be used (to be merged with deployment spec), but after multiple tries I did not find any working formula with this key :sad

┆Issue is synchronized with this Asana task by Unito

[github-actions]

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.

[sam-heilbron]

See #8025 (comment) for more context. This was resolved in GG Enterprise 1.17.1 and will be in 1.18.0-beta1