Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing include in gateway- proxy yaml #9731

Closed
AlfredoFausto opened this issue Jul 5, 2024 · 1 comment
Closed

Missing include in gateway- proxy yaml #9731

AlfredoFausto opened this issue Jul 5, 2024 · 1 comment
Assignees
Labels
Area: Helm Area: UX Impact: M Priority: Medium Not required over next 3 months but users have keen interest in seeing Issues delivered. release/1.16 Type: Bug Something isn't working

Comments

@AlfredoFausto
Copy link

Gloo Edge Product

Enterprise

Gloo Edge Version

1.16.9

Kubernetes Version

1.27

Describe the bug

Trying to configure the priorityClassName with helm values didn't reflect the changes in the chart.
Example:

This is the values file used


gloo:
  gatewayProxies:
    gatewayProxy:
      kind:
        deployment:
          kubeResourceOverride:
            spec:
              template:
                spec:
                  priorityClassName:

The docs specify how should used:
gloo.gatewayProxies.gatewayProxy.kind.deployment.kubeResourceOverride.NAME
https://docs.solo.io/gloo-edge/latest/reference/helm_chart_values/enterprise_helm_chart_values/#helm-chart-kuberesourceoverrides

In the helpers, we should have

https://github.com/solo-io/gloo/blob/ed1dbf08542b51888cbb66a7f134dad8be94b05c/install/helm/gloo/templates/_helpers.tpl#L68

{{- define "gloo.podSpecStandardFields" -}}

But this include is missing in the template install/helm/gloo/templates/7-gateway-proxy-deployment.yaml

Expected Behavior

I would expect using the values we have in the docs should work as-is.
Delete the include was removed by accident or deprecation without notice.

Steps to reproduce the bug

Template the chart with the values file above and a verify the rendered yaml

Additional Environment Detail

Kind 1.27
Helm 3.15.1
Gloo we 1.16.9

Additional Context

No response

@sam-heilbron
Copy link
Contributor

See #8025 (comment) for more context. This was resolved in GG Enterprise 1.17.1 and will be in 1.18.0-beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Helm Area: UX Impact: M Priority: Medium Not required over next 3 months but users have keen interest in seeing Issues delivered. release/1.16 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants