Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old configuration support is broken #133

Closed
andriymoroz opened this issue Dec 12, 2017 · 1 comment · Fixed by sonic-net/sonic-buildimage#1263
Closed

Old configuration support is broken #133

andriymoroz opened this issue Dec 12, 2017 · 1 comment · Fixed by sonic-net/sonic-buildimage#1263

Comments

@andriymoroz
Copy link

The commit "[dockers] Remove dependency to minigraph" breaks the support of old minigraphs which do not have neighbors listed in section <Devices>.
Option "-m" for sonic-cfggen helped to generate empty DEVICE_NEIGHBOR_METADATA. Without it it is not generated and buffers configuration template fails.
New minigraphs work ok.

@liatgrozovik
Copy link

@andriymoroz does it mean that we need as part of sonic upgrade to generate new minigraph?
@lguohan what should be the preferred behaviour to a user? If i remember correct we discussed that we will have minigraph as backwards compatibility, if this is not the case any more we need to provide different guidelines for the users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants