Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check gather result compatibility before summarizing with tax #2245

Closed
bluegenes opened this issue Aug 30, 2022 · 1 comment
Closed

check gather result compatibility before summarizing with tax #2245

bluegenes opened this issue Aug 30, 2022 · 1 comment

Comments

@bluegenes
Copy link
Contributor

Summarizing gather results with sourmash taxonomy is only valid across gather runs that used the same parameters.

Now that ksize, moltype (and scaled?) are columns in the gather csv, we should use these to make sure we're only summarizing over the same params!

punted from #2155
@bluegenes
Copy link
Contributor Author

Closed via recent taxonomy refactoring (#2443)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bluegenes