Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage directory contents inadvertently included with npm, please remove #45

Open
cstrong opened this issue Jun 1, 2017 · 2 comments

Comments

@cstrong
Copy link

cstrong commented Jun 1, 2017

spdy-transport npm includes a coverage directory that has a coverage.json file in it.
This is somehow picked up by istanbul in other unrelated projects and it wreaks havoc.
Let me know if I am missing anything, but I believe this problem exists in the latest release

@cstrong cstrong changed the title coverage directory contents inadvertently checked into Git, please remove coverage directory contents inadvertently included with npm, please remove Jun 1, 2017
@cstrong
Copy link
Author

cstrong commented Jun 1, 2017

This is what I am getting in my project. I am still not sure exactly how this file gets picked up, perhaps a really sloppy regex?

`Error: ENOENT: no such file or directory, open '/Users/koruza/code/spdy-transport/lib/spdy-transport.js'

at Error (native)
at Object.fs.openSync (fs.js:640:18)
at Object.fs.readFileSync (fs.js:508:33)
at LookupStore.get (/usr/src/app/node_modules/istanbul/lib/store/fslookup.js:40:19)
at HtmlReport.writeDetailPage (/usr/src/app/node_modules/istanbul/lib/report/html.js:406:67)
at /usr/src/app/node_modules/istanbul/lib/report/html.js:484:26
at AsyncFileWriter.processFile (/usr/src/app/node_modules/istanbul/lib/util/file-writer.js:93:9)
at /usr/src/app/node_modules/async/lib/async.js:929:13
at Immediate.process (/usr/src/app/node_modules/async/lib/async.js:897:25)
at runCallback (timers.js:637:20)

Exited with code: 1.
Warning: Task "exec:coverage:html:test/unit" failed. Use --force to continue.`

@joshas
Copy link

joshas commented Jan 18, 2018

Issue still exists in latest release v2.0.20. It adds almost 1MB of unnecessary data to node_modules directory when spdy-transport package is included.
Looks like fix was made here: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants