-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Python coroutines #4847
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4847 +/- ##
==========================================
+ Coverage 82.15% 82.15% +<.01%
==========================================
Files 289 289
Lines 38141 38157 +16
Branches 5915 5918 +3
==========================================
+ Hits 31333 31347 +14
- Misses 5488 5490 +2
Partials 1320 1320
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for very late reviewing.
LGTM with nits.
Could you add testcase for coroutines please?
ping. The feature freeze for Sphinx-1.8 comes soon (see #4986). I really want to merge this into next release. |
Fixed by #6295 instead. |
Subject: Add support for Python coroutines
This feature was proposed in #4777.
I've split the patch I proposed into 3 different changesets, and simplified the autodoc part by putting the async check into the common Documenter.add_directive_header instead of its subclasses, which may or may not be to your liking. I can go back to overriding add_directive_header in the subclasses if you prefer that, but I doubt it makes much practical difference.