RestTemplateBuilder.basicAuth causes the entire body to be read into memory #17010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: bug
|
Nice one! Thanks. |
nosan
force-pushed
the
gh-15078
branch
5 times, most recently
from
e29a463
to
67ea430
Compare
…equest factory to add authentication headers. Prior to this commit, the `RestTemplateBuilder` and `TestRestTemplate` used the `BasicAuthenticationInterceptor` interceptor to add headers. Unfortunately, adding any interceptor causes the entire message body to be read into a byte array. This causes an `OutOfMemoryError` whenever a large file is uploaded. Closes spring-projectsgh-15078
philwebb
pushed a commit
that referenced
this pull request
Jun 1, 2019
Update `RestTemplateBuilder` to use a custom request factory to add authentication headers rather than an interceptor. Prior to this commit, the use of the `BasicAuthenticationInterceptor` interceptor could cause `OutOfMemoryError` whenever a large file is uploaded. See gh-17010
philwebb
added a commit
that referenced
this pull request
Jun 1, 2019
Reduce the surface area of the public API by making the `BasicAuthentication` and `BasicAuthenticationClientHttpRequestFactory` class package private. This commit also attempts to simplify `TestRestTemplate` by keeping the `RestTemplateBuilder` and reusing it, rather than needing to deal only with a `RestTemplate` instance. See gh-17010
|
Thanks for another contribution @nosan !! This has now been merged to master. I've add a polish commit that makes some of the new classes package private just to reduce the surface area of the public API. |
wilkinsona
pushed a commit
to wilkinsona/spring-boot
that referenced
this pull request
Jun 4, 2019
Update `RestTemplateBuilder` to use a custom request factory to add authentication headers rather than an interceptor. Prior to this commit, the use of the `BasicAuthenticationInterceptor` interceptor could cause `OutOfMemoryError` whenever a large file is uploaded. See spring-projectsgh-17010
wilkinsona
pushed a commit
to wilkinsona/spring-boot
that referenced
this pull request
Jun 4, 2019
Reduce the surface area of the public API by making the `BasicAuthentication` and `BasicAuthenticationClientHttpRequestFactory` class package private. This commit also attempts to simplify `TestRestTemplate` by keeping the `RestTemplateBuilder` and reusing it, rather than needing to deal only with a `RestTemplate` instance. See spring-projectsgh-17010
wilkinsona
changed the title
RestTemplateBuilder and TestRestTemplate to use BasicAuthenticationClientHttpRequestFactory instead of Interceptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
RestTemplateBuilderandTestRestTemplateto use a custom request factory to addauthentication headers.
Prior to this commit, the
RestTemplateBuilderandTestRestTemplateused theBasicAuthenticationInterceptorto add headers.see gh-15078