Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of ClassLoader.loadClass() in ConfigurationClassParser [SPR-17253] #21786

Closed
spring-projects-issues opened this issue Sep 7, 2018 · 0 comments
Closed

Usage of ClassLoader.loadClass() in ConfigurationClassParser [SPR-17253] #21786

spring-projects-issues opened this issue Sep 7, 2018 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.0.9

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Sep 7, 2018 •
edited
Loading

Dave Syer opened SPR-17253 and commented

In ConfigurationClassParser we explicitly call ClassLoader.loadClass() which is a bit odd, given that we have ClassUtils to do that work for us, and that is the "normal" pattern in Spring internally. It wouldn't affect any regular apps if we refactored to use ClassUtils (I tried it and the tests all pass). It would affect AOT native images in a positive way: the ClassLoader is null in that case, but Class.forName() actually works.

Affects: 5.0.8

Issue Links:

Referenced from: commits ad54472, c803ad7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.0.9
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues