Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing Hooks.onLastOperator by a better propagation mechanism #14356

Closed
marcusdacoregio opened this issue Dec 20, 2023 · 1 comment
Closed

Consider replacing Hooks.onLastOperator by a better propagation mechanism #14356

marcusdacoregio opened this issue Dec 20, 2023 · 1 comment
Assignees
@marcusdacoregio
Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement

Comments

@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Dec 20, 2023 •
edited
Loading

Currently, we use Hooks.onLastOperator to propagate the SecurityContext, request and response to the reactor operator chain in tests. See https://github.com/spring-projects/spring-security/blob/main/config/src/main/java/org/springframework/security/config/annotation/web/configuration/SecurityReactorContextConfiguration.java#L83 and https://github.com/spring-projects/spring-security/blob/main/test/src/main/java/org/springframework/security/test/context/support/ReactorContextTestExecutionListener.java#L75.

However, such hook does not cover some corner cases. We should investigate more and consider moving to a better propagation mechanism.

Related:
@marcusdacoregio marcusdacoregio added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement for: team-attention This ticket should be discussed as a team before proceeding labels Dec 20, 2023
@marcusdacoregio marcusdacoregio removed the for: team-attention This ticket should be discussed as a team before proceeding label Feb 1, 2024
@marcusdacoregio
Copy link
Contributor Author

Closing as duplicate of #13733

@marcusdacoregio marcusdacoregio self-assigned this Feb 1, 2024
@marcusdacoregio marcusdacoregio added the status: duplicate A duplicate of another issue label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcusdacoregio