Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucan 0.10 #510

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

ucan 0.10 #510

wants to merge 42 commits into from

Conversation

chunningham
Copy link
Member

@chunningham chunningham commented Apr 17, 2023

Updates the ucan impl to match the upcoming 0.10 version of the spec. This pr also removes a lot of the IPLD stuff as that will be covered by the cacao crate. Because of this, it removes tracking of the codec and implements verification in tandem with deserialisation so that it can have the original serialisation to verify. It also depends on the as-yet unreleased ucan-capabilities-object crate.

probable TODOs:

  • tests, there are currently no independent 0.10 ucan test vectors that I'm aware of
  • ucan-capabilities-object has to be released

Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review in detail, but it's mostly just removing code.

Could you rebase on latest main?

ssi-ucan/Cargo.toml Outdated Show resolved Hide resolved
ssi-ucan/src/lib.rs Outdated Show resolved Hide resolved
@sbihel
Copy link
Member

sbihel commented May 4, 2023

Looks like some tests are failing

@chunningham
Copy link
Member Author

There's no test vectors anywhere for ucan 0.10, so I wasn't sure which to use. I will generate some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants