Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where an error in a proof verification allowed a positive… #527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vdods
Copy link
Contributor

@vdods vdods commented Aug 16, 2023

… Check::Proof to be added to the verification results in addition to the expected error. This fixes it to match the analogous logic in other proof verification code.

… Check::Proof to be added to the verification results in addition to the expected error. This fixes it to match the analogous logic in other proof verification code.
@vdods
Copy link
Contributor Author

vdods commented Aug 16, 2023

This only required fixing a typo. The bug in particular was that I was seeing

VerificationResult { checks: [Proof], warnings: [], errors: [ "signature error: Verification equation was not satisfied" ] }

when I should have been seeing

VerificationResult { checks: [], warnings: [], errors: [ "signature error: Verification equation was not satisfied" ] }

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2024

CLA assistant check
All committers have signed the CLA.

@vdods
Copy link
Contributor Author

vdods commented Aug 20, 2024

Same deal here, I sent in a signed CLA Oct 6, 2021, but let me know if you need a new one for whatever reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants