Merge branch 'php-8.0/generic-unused-parameter-add-support-constr-pro…

…p-prom' of https://github.com/jrfnl/PHP_CodeSniffer
squizlabs · Mar 16, 2021 · 6825333 · 6825333
2 parents dc59530 + 529043f
commit 6825333
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Standards/Generic/Sniffs/CodeAnalysis/UnusedFunctionParameterSniff.php b/src/Standards/Generic/Sniffs/CodeAnalysis/UnusedFunctionParameterSniff.php
@@ -90,6 +90,11 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         foreach ($methodParams as $param) {
+            if (isset($param['property_visibility']) === true) {
+                // Ignore. Constructor property promotion.
+                continue;
+            }
+
             $params[$param['name']] = $stackPtr;
         }
 

diff --git a/src/Standards/Generic/Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.inc b/src/Standards/Generic/Tests/CodeAnalysis/UnusedFunctionParameterUnitTest.inc
@@ -137,3 +137,16 @@ function moreParamFirst(Exception $foo, LogicException $bar) {
 function moreParamSecond(LogicException $bar, Exception $foo) {
     return 'foobar' . $bar;
 }
+// phpcs:set Generic.CodeAnalysis.UnusedFunctionParameter ignoreTypeHints[]
+
+class ConstructorPropertyPromotionNoContentInMethod {
+    public function __construct(protected int $id) {}
+}
+
+class ConstructorPropertyPromotionWithContentInMethod {
+    public function __construct(protected int $id, $toggle = true) {
+        if ($toggle === true) {
+            doSomething();
+        }
+    }
+}