File::isReference(): simplify code

The `File::getMethodParameters()` returns a `reference_token` index, so no need to do any token walking.
squizlabs · Sep 5, 2020 · 76fce40 · 76fce40
1 parent 1371c59
commit 76fce40
Showing 1 changed file with 1 addition and 13 deletions.
diff --git a/src/Files/File.php b/src/Files/File.php
@@ -1981,19 +1981,7 @@ public function isReference($stackPtr)
                 ) {
                     $params = $this->getMethodParameters($this->tokens[$lastBracket]['parenthesis_owner']);
                     foreach ($params as $param) {
-                        $varToken = $tokenAfter;
-                        if ($param['variable_length'] === true) {
-                            $varToken = $this->findNext(
-                                (Util\Tokens::$emptyTokens + [T_ELLIPSIS]),
-                                ($stackPtr + 1),
-                                null,
-                                true
-                            );
-                        }
-
-                        if ($param['token'] === $varToken
-                            && $param['pass_by_reference'] === true
-                        ) {
+                        if ($param['reference_token'] === $stackPtr) {
                             // Function parameter declared to be passed by reference.
                             return true;
                         }