From f3833cc5d75d8a24d7b7b47407de60c98310e37b Mon Sep 17 00:00:00 2001 From: Vincent Langlet Date: Thu, 23 Apr 2020 02:07:19 +0200 Subject: [PATCH] Handle square bracket --- .../PEAR/Sniffs/Functions/FunctionCallSignatureSniff.php | 1 + .../PEAR/Tests/Functions/FunctionCallSignatureUnitTest.inc | 7 +++++-- .../Functions/FunctionCallSignatureUnitTest.inc.fixed | 5 ++++- .../PEAR/Tests/Functions/FunctionCallSignatureUnitTest.php | 1 + 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/Standards/PEAR/Sniffs/Functions/FunctionCallSignatureSniff.php b/src/Standards/PEAR/Sniffs/Functions/FunctionCallSignatureSniff.php index 162d5e7acf..a4131fe65c 100644 --- a/src/Standards/PEAR/Sniffs/Functions/FunctionCallSignatureSniff.php +++ b/src/Standards/PEAR/Sniffs/Functions/FunctionCallSignatureSniff.php @@ -66,6 +66,7 @@ public function register() $tokens[] = T_VARIABLE; $tokens[] = T_CLOSE_CURLY_BRACKET; + $tokens[] = T_CLOSE_SQUARE_BRACKET; $tokens[] = T_CLOSE_PARENTHESIS; return $tokens; diff --git a/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.inc b/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.inc index eaa983cc06..6b2c898c42 100644 --- a/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.inc +++ b/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.inc @@ -90,7 +90,7 @@ $bar = new stdClass( 4, 5, 6 - + ); $bar = new stdClass( @@ -199,7 +199,7 @@ function foo() myFunction( 'string'. // comment - // comment + // comment 'string'. /* comment * comment @@ -522,3 +522,6 @@ return trim(preg_replace_callback( }, $search )); + +$a = ['a' => function ($b) { return $b; }]; +$a['a']( 1 ); diff --git a/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.inc.fixed b/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.inc.fixed index e040fc8ae6..7396441878 100644 --- a/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.inc.fixed +++ b/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.inc.fixed @@ -204,7 +204,7 @@ function foo() myFunction( 'string'. // comment - // comment + // comment 'string'. /* comment * comment @@ -534,3 +534,6 @@ return trim( $search ) ); + +$a = ['a' => function ($b) { return $b; }]; +$a['a'](1); diff --git a/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.php b/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.php index ae34072537..c6db5b08e5 100644 --- a/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.php +++ b/src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.php @@ -125,6 +125,7 @@ public function getErrorList($testFile='FunctionCallSignatureUnitTest.inc') 514 => 1, 523 => 1, 524 => 3, + 527 => 2, ]; }//end getErrorList()