From 76fce40bbc71b1f8c2935c3afc17a888bfa72b2f Mon Sep 17 00:00:00 2001 From: jrfnl Date: Sat, 5 Sep 2020 22:54:34 +0200 Subject: [PATCH] File::isReference(): simplify code The `File::getMethodParameters()` returns a `reference_token` index, so no need to do any token walking. --- src/Files/File.php | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/src/Files/File.php b/src/Files/File.php index 9a34bd0f43..b7e35488f0 100644 --- a/src/Files/File.php +++ b/src/Files/File.php @@ -1981,19 +1981,7 @@ public function isReference($stackPtr) ) { $params = $this->getMethodParameters($this->tokens[$lastBracket]['parenthesis_owner']); foreach ($params as $param) { - $varToken = $tokenAfter; - if ($param['variable_length'] === true) { - $varToken = $this->findNext( - (Util\Tokens::$emptyTokens + [T_ELLIPSIS]), - ($stackPtr + 1), - null, - true - ); - } - - if ($param['token'] === $varToken - && $param['pass_by_reference'] === true - ) { + if ($param['reference_token'] === $stackPtr) { // Function parameter declared to be passed by reference. return true; }