Squiz.Formatting.OperatorBracket reporting false positive for exit st…

…atements (ref #3099)
squizlabs · Sep 13, 2020 · fad249a · fad249a
1 parent 2f844c3
commit fad249a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/src/Standards/Squiz/Sniffs/Formatting/OperatorBracketSniff.php b/src/Standards/Squiz/Sniffs/Formatting/OperatorBracketSniff.php
@@ -107,6 +107,7 @@ public function process(File $phpcsFile, $stackPtr)
                 T_OPEN_CURLY_BRACKET  => true,
                 T_OPEN_SHORT_ARRAY    => true,
                 T_CASE                => true,
+                T_EXIT                => true,
             ];
 
             if (isset($invalidTokens[$tokens[$previousToken]['code']]) === true) {

diff --git a/src/Standards/Squiz/Tests/Formatting/OperatorBracketUnitTest.inc b/src/Standards/Squiz/Tests/Formatting/OperatorBracketUnitTest.inc
@@ -172,3 +172,5 @@ $test = (1 * static::TEST);
 $test = myfunc(1 * static::TEST);
 
 $errorPos = $params[$x]?->getLine() + $commentStart;
+
+exit -1;
diff --git a/src/Standards/Squiz/Tests/Formatting/OperatorBracketUnitTest.inc.fixed b/src/Standards/Squiz/Tests/Formatting/OperatorBracketUnitTest.inc.fixed
@@ -172,3 +172,5 @@ $test = (1 * static::TEST);
 $test = myfunc(1 * static::TEST);
 
 $errorPos = ($params[$x]?->getLine() + $commentStart);
+
+exit -1;