Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM header tag "copyright" should be "license" #44

Open
tpodowd opened this issue Oct 9, 2023 · 2 comments
Open

RPM header tag "copyright" should be "license" #44

tpodowd opened this issue Oct 9, 2023 · 2 comments

Comments

@tpodowd
Copy link

tpodowd commented Oct 9, 2023

According to https://rpm-software-management.github.io/rpm/manual/tags.html , tag 1014 should called license and not copyright.

Here is one example:

"copyright": 1014,

RPMTAG_COPYRIGHT = 1014

RPMTAG_COPYRIGHT,

In the main cli command you are already changing the header title to License...

rpmfile/rpmfile/cli.py

Lines 79 to 87 in 185ac91

headers_titles = {
"name": "Name",
"version": "Version",
"release": "Release",
"arch": "Architecture",
"group": "Group",
"size": "Size",
"copyright": "License",
"signature": "Signature",

The rpm command itself also does not find a copyright header tag.

$ rpm -q --qf "%{LICENSE}\n" bash
GPLv3+
$ rpm -q --qf "%{COPYRIGHT}\n" bash
error: incorrect format: unknown tag: "COPYRIGHT"
@pdxjohnny
Copy link
Collaborator

Are you looking for an alias for the variable or a rename?

@tpodowd
Copy link
Author

tpodowd commented Nov 9, 2023

Hi @pdxjohnny - Thanks for your reply. I would think an alias makes more sense at this stage as folks may already be using copyright. Perhaps, change the the field to license and then make copyright the alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants