Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for disabling search result icons entirely #502

Open
2 tasks done
h0rn3z0r opened this issue Jun 9, 2024 · 3 comments
Open
2 tasks done

Add option for disabling search result icons entirely #502

h0rn3z0r opened this issue Jun 9, 2024 · 3 comments
Labels
feature idea Requested feature p:3 Priority 3

Comments

@h0rn3z0r
Copy link

h0rn3z0r commented Jun 9, 2024

Preflight Checklist

  • I have fully read the README and it did not solve the problem.
  • I have searched all open and closed issues for the same bug report without success.

EverythingToolbar Version

1.3.3.0

Everything Version

1.4.1.1024 (x64)

Windows Version

Windows 10 22H2

Steps to reproduce

  1. Open Resource Monitor and select Disk tab
  2. Open EverythingToolbar and apply my settings shown below
  3. Start scrolling down
  4. Notice how explorer.exe tries to access every file found

Expected Behavior

No disk usage, file info should be read from index stored in RAM, like Everything does

Actual Behavior

EverythingToolbar retrieves info directly from disk, but all necessary properties (path, last modified and file size) are already indexed

Screenshots

image image

Log output

2024-06-09 15:33:19.6334|INFO|CSDeskBand.CSDeskBandWpf|EverythingToolbar 1.3.3.0 started. OS: Microsoft Windows NT 10.0.19045.0|
2024-06-09 20:05:23.1063|INFO|EverythingToolbar.EverythingSearch|Everything version: 1.4.1|

Additional Information

No response

@srwi
Copy link
Owner

srwi commented Jun 9, 2024

Hi @h0rn3z0r, this is caused by reading the file icons from disk. Once I disable that in code, disk utilization is reduced again. Can you quantify "high disk usage"? For me it is very minor (<0.5 MB/s) and I would not consider that a problem.

@h0rn3z0r
Copy link
Author

h0rn3z0r commented Jun 9, 2024

Hi @h0rn3z0r, this is caused by reading the file icons from disk. Once I disable that in code, disk utilization is reduced again. Can you quantify "high disk usage"? For me it is very minor (<0.5 MB/s) and I would not consider that a problem.

Oh I see, the problem for me is not the amount of bytes read, the problem is that my hard drives are in standby mode most of the time and each search attempt causes unnecessary wake up and a minor freeze.
Everything has an /icon_shell_extensions=0 INI setting (see relevant issue). It would be nice to have such toggle in the Toolbar also.

@srwi
Copy link
Owner

srwi commented Jun 11, 2024

I see, I guess that could be a power user flag just like in Everything. There would have to be a placeholder icon though so this will take a tiny bit of implementation effort.

@srwi srwi added the feature idea Requested feature label Jun 11, 2024
@srwi srwi changed the title High disk usage while searching Add option for disabling search result icons entirely Jun 11, 2024
@srwi srwi added the p:3 Priority 3 label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature idea Requested feature p:3 Priority 3
Projects
None yet
Development

No branches or pull requests

2 participants