Bug: No types on Deno

[guy-borderless]

Description

Hello!
when importing xstate in deno like so:
import * as xstate from "https://deno.land/x/xstate@xstate@4.35.2/src/index.ts";

loaded code has no types, probably since xstate doesn't use the .ts file extensions when importing files.
import { createMachine, Machine } from './Machine';
=>
import { createMachine, Machine } from './Machine.ts';

Expected result

typescript types should be loaded

Actual result

everything is typed as any

Reproduction

import * as xstate from "https://deno.land/x/xstate@xstate@4.35.2/src/index.ts";

Additional context

No response

[Andarist]

This will be fixed in the next major version of XState.

[Andarist]

We landed the appropriate change on the next branch: #3765

[Andarist]

Actually, while that PR switches the repo to moduleResolution: node16 and thus to using explicit extensions - it doesn't fix the issue at hand here. The repo is now using .js extensions in import sources - but Deno won't understand it as it's actually using .ts.

We gonna fix this and provide a way to import XState correctly in Deno but I need to rethink our options.

[davidkpiano]

Can you check xstate@beta and see if it now has types?

[guy-borderless]

importing xstate 5 latest- alpha 6 I see types!
import * as xstate from "https://deno.land/x/xstate@xstate@5.0.0-alpha.6/src/index.ts"

Thanks a lot!

[Andarist]

How does deno.land work today with the recently added support for node_modules in deno? It feels to me that, ideally, you shouldn't reach into /src sirectory when importing xstate.

[guy-borderless]

Personally I like that this style of import is not abstracted, like it is with local imports. Easier to debug and understand imported code IMO. For the main module in deno there is a mod.ts convention. Also, This is an interesting read. if I understand correctly the next version of deno will formalize the mod.ts pattern to encourage npm style import with the "deno:" URL scheme (and I'm sure they'll generalize for file servers hosting ESM). I think the more ESM the better, great ergonomics and less power to npm.

[davidkpiano]

Closing as it seems that xstate@beta in Deno how provides types 🎉

Feel free to reopen if some details are still missing about this.

EDIT: not closed yet

[Andarist]

I’d definitely like to figure out a better way for Deno users to consume our package. Relying in the src directory isn’t stable and could break for subtle reasons at any time

[guy-borderless]

I’d definitely like to figure out a better way for Deno users to consume our package. Relying in the src directory isn’t stable and could break for subtle reasons at any time

mod.ts

[guy-borderless]

npm import works now
import { createMachine } from 'npm:xstate'

[davidkpiano]

npm import works now import { createMachine } from 'npm:xstate'

Great, thanks for the update!