Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet: user is navigated to the wrong screen when sending a token from the drawer and selecting one of their accounts #19225

Closed
Tracked by #19090
qoqobolo opened this issue Mar 13, 2024 · 5 comments · Fixed by #19123
Assignees
Labels

Comments

@qoqobolo
Copy link
Contributor

Bug Report

Problem

If you long-press a token to send it from the drawer, after selecting one of your accounts as a receiver, you'll be redirected to the Select asset screen, which doesn't look right, since you're already sending a particular asset.

Reproduction

  1. Open Wallet
  2. Open an account
  3. Long-press on a token
  4. Press Send
  5. Open the My accounts tab, select one of your accounts

Expected behavior

The screen with the token amount input field is opened

https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&node-id=7701-157251&mode=design&t=i4lglrtuSUyZWRSc-4

Screenshot 2024-03-13 at 11 46 12

Actual behavior

The Select asset screen is opened

video_2024-03-12_16-36-23.mp4

Additional Information

  • Status version: nightly 13/03
  • Operating System: Android, iOS
@J-Son89
Copy link
Contributor

J-Son89 commented Mar 19, 2024

@qoqobolo - thanks for raising this.
@ulisesmac, this is related to the discussion we were having earlier.
Can you either make use of this issue or close this issue when you create the other one? (@qoqobolo the solution for this is somewhat generic as we will leverage the code @mmilad75 is adding here: #19123

@ulisesmac ulisesmac self-assigned this Mar 19, 2024
@ulisesmac
Copy link
Contributor

Thanks @J-Son89 nad @qoqobolo

I'm taking this issue and I'll solve it when @mmilad75's PR gets merged,

@J-Son89
Copy link
Contributor

J-Son89 commented Mar 19, 2024

In fact @mmilad75's pr might even solve this already 👍

@J-Son89
Copy link
Contributor

J-Son89 commented Mar 20, 2024

I'm pretty sure Milad's pr resolves this 👍

@ulisesmac
Copy link
Contributor

Thanks, I'm assigning this to @mmilad75 then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

4 participants