Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: apply fixes to all the codebase with cargo clippy --fix #739

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore: apply fixes to all the codebase with cargo clippy --fix #739

wants to merge 5 commits into from

Commits on Sep 4, 2024

  1. fix: allow commas and semicolons between fields in constant messages 

    According to the Protobuf Specification the fields in a constant message can be separated by spaces, commas or semicolons. All the following variants are accepted by the official compiler`protoc`.

```
{foo: 1,bar: 2,baz: 3,}
{foo: 1;bar: 2;baz: 3;}
{foo: 1 bar: 2 baz: 3}
{foo: 1,bar: 2;baz: 3}
{foo: 1,bar: 2 baz: 3}
```
    @plusvic
    plusvic committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9d32945 View commit details
    Browse the repository at this point in the history

  2. fix: minor spacing issue while formatting constant messages

    @plusvic
    plusvic committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6d98aba View commit details
    Browse the repository at this point in the history

  3. style: fix format

    @plusvic
    plusvic committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6951916 View commit details
    Browse the repository at this point in the history

  4. chore: apply fixes to all the codebase with cargo clippy --fix 

    Checking the source code with Clippy is a good practice that helps maintaining the code in good shape and ensures an homogeneous style. Most of the automatic fixes in this commit are small cosmetic changes, but some of them improve legibility or even performance.

If this change is accepted I plan to keep applying more fixes for hints that Clippy reports but can't fix automatically.
    @plusvic
    plusvic committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    35d421f View commit details
    Browse the repository at this point in the history

  5. style: run cargo fmt --all

    @plusvic
    plusvic committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    dd08537 View commit details
    Browse the repository at this point in the history