From fd2b245c7e69b342c0c651d5a08fb4c8f28a11cd Mon Sep 17 00:00:00 2001 From: Radek Zikmund <32671551+rzikm@users.noreply.github.com> Date: Wed, 31 Jul 2024 13:09:51 +0200 Subject: [PATCH] Add timeouts to QuicConnectionTests for StreamsAvailable tests (#105699) --- .../tests/FunctionalTests/QuicConnectionTests.cs | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs b/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs index 7fb4da2e9a087..10521e4abbc5a 100644 --- a/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs +++ b/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs @@ -265,7 +265,7 @@ public async Task GetStreamCapacity_OpenCloseStream_CountsCorrectly() }; (QuicConnection clientConnection, QuicConnection serverConnection) = await CreateConnectedQuicConnection(clientOptions); - await streamsAvailableFired.WaitAsync(); + await streamsAvailableFired.WaitAsync().WaitAsync(PassingTestTimeout); Assert.Equal(QuicDefaults.DefaultServerMaxInboundBidirectionalStreams, bidiIncrement); Assert.Equal(QuicDefaults.DefaultServerMaxInboundUnidirectionalStreams, unidiIncrement); @@ -275,7 +275,7 @@ public async Task GetStreamCapacity_OpenCloseStream_CountsCorrectly() await serverStreamBidi.DisposeAsync(); // STREAMS_AVAILABLE event comes asynchronously, give it a chance to propagate - await streamsAvailableFired.WaitAsync(); + await streamsAvailableFired.WaitAsync().WaitAsync(PassingTestTimeout); Assert.Equal(1, bidiIncrement); Assert.Equal(0, unidiIncrement); @@ -285,7 +285,7 @@ public async Task GetStreamCapacity_OpenCloseStream_CountsCorrectly() await serverStreamUnidi.DisposeAsync(); // STREAMS_AVAILABLE event comes asynchronously, give it a chance to propagate - await streamsAvailableFired.WaitAsync(); + await streamsAvailableFired.WaitAsync().WaitAsync(PassingTestTimeout); Assert.Equal(0, bidiIncrement); Assert.Equal(1, unidiIncrement); @@ -314,7 +314,7 @@ public async Task GetStreamCapacity_OpenCloseStreamIntoNegative_CountsCorrectly( }; (QuicConnection clientConnection, QuicConnection serverConnection) = await CreateConnectedQuicConnection(clientOptions); - await streamsAvailableFired.WaitAsync(); + await streamsAvailableFired.WaitAsync().WaitAsync(PassingTestTimeout); Assert.Equal(QuicDefaults.DefaultServerMaxInboundBidirectionalStreams, bidiIncrement); Assert.Equal(QuicDefaults.DefaultServerMaxInboundUnidirectionalStreams, unidiIncrement); Assert.Equal(QuicDefaults.DefaultServerMaxInboundBidirectionalStreams, bidiTotal); @@ -353,7 +353,7 @@ public async Task GetStreamCapacity_OpenCloseStreamIntoNegative_CountsCorrectly( { await clientStream.DisposeAsync(); await (await serverConnection.AcceptInboundStreamAsync()).DisposeAsync(); - await streamsAvailableFired.WaitAsync(); + await streamsAvailableFired.WaitAsync().WaitAsync(PassingTestTimeout); Assert.Equal(unidirectional ? 0 : (first ? QuicDefaults.DefaultServerMaxInboundBidirectionalStreams + 1 : 1), bidiIncrement); Assert.Equal(unidirectional ? (first ? QuicDefaults.DefaultServerMaxInboundUnidirectionalStreams + 1 : 1) : 0, unidiIncrement); first = false; @@ -387,7 +387,7 @@ public async Task GetStreamCapacity_OpenCloseStreamCanceledIntoNegative_CountsCo }; (QuicConnection clientConnection, QuicConnection serverConnection) = await CreateConnectedQuicConnection(clientOptions); - await streamsAvailableFired.WaitAsync(); + await streamsAvailableFired.WaitAsync().WaitAsync(PassingTestTimeout); Assert.Equal(QuicDefaults.DefaultServerMaxInboundBidirectionalStreams, bidiIncrement); Assert.Equal(QuicDefaults.DefaultServerMaxInboundUnidirectionalStreams, unidiIncrement); Assert.Equal(QuicDefaults.DefaultServerMaxInboundBidirectionalStreams, bidiTotal); @@ -426,7 +426,7 @@ public async Task GetStreamCapacity_OpenCloseStreamCanceledIntoNegative_CountsCo { Assert.True(cancelledStream.IsCanceled); await (await serverConnection.AcceptInboundStreamAsync()).DisposeAsync(); - await streamsAvailableFired.WaitAsync(); + await streamsAvailableFired.WaitAsync().WaitAsync(PassingTestTimeout); Assert.Equal(unidirectional ? 0 : (first ? QuicDefaults.DefaultServerMaxInboundBidirectionalStreams + 1 : 1), bidiIncrement); Assert.Equal(unidirectional ? (first ? QuicDefaults.DefaultServerMaxInboundUnidirectionalStreams + 1 : 1) : 0, unidiIncrement); first = false;