Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graal support (native image) #2

Closed
soberich opened this issue Sep 26, 2019 · 5 comments
Closed

Graal support (native image) #2

soberich opened this issue Sep 26, 2019 · 5 comments

Comments

@soberich
Copy link

soberich commented Sep 26, 2019

Just a label to track support of Graal. Particularly native-image.
There should be of course support from Graal itself first (MH) and probably JDK?

So probably at some point current implementation would be able to be build into native-image as is, but it is also possible that author will decide to workaround before that will naturally occur (as it might take really long time)?

@stevenschlansker what do you think?

@stevenschlansker
Copy link
Owner

Is there a specific problem you're aware of regarding native image support currently?
I read through the documentation and (without having tested it) it sounded like it should work with the code as it exists today.

@soberich
Copy link
Author

I thought there are issues preventing it to be compiled to native-image.
oracle/graal#955 (comment)
Good to now there aren't.
I will close it then.

@stevenschlansker
Copy link
Owner

I was hoping that we fall under this clause:

Method handles initialized in a class initializer and then used just to invoke a method or access a field are fully supported. Use cases for that are method handles initialized once to access private memembers.

Of course, testing is appreciated -- did you try it?

@soberich
Copy link
Author

soberich commented Dec 8, 2019

@stevenschlansker though I still haven't tried this is a part I was talking about.

/**
 * The following substitution replaces the usage of {@code MethodHandle} in {@code Java9ChecksumFactory} with a plain
 * constructor invocation when run under GraalVM. This is necessary because the native image generator does not support method
 * handles.
 */

quarkusio/quarkus@68584cb

@stevenschlansker
Copy link
Owner

Hm... well, I suppose there's not much to do but try it and see if it's actually an issue here 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants